Work #384, #640, #672, Minor fixes to osal config guide #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrogeco
added
docs
and removed
CCB:PendingCLA
|
Thanks for the contribution Andrei! |
jphickey
approved these changes
May 4, 2021
|
Hi again @Kronos3, if you haven't done so already please, download, sign, and email the appropriate Contributor License agreement below to GSFC-SoftwareRelease@mail.nasa.gov and cfs-program@lists.nasa.gov. Corporate Contributor License agreement THANKS! |
astrogeco
added
the
CCB:PendingCLA
|
Hi @astrogeco, I submitted the license agreement, should I expect a reply (submitted 3 days ago)? |
astrogeco
changed the title
astrogeco
changed the title
astrogeco
added
IC:2021-05-18
and removed
CCB:PendingCLA
|
Thanks Andrei! Had some kinks in the process internally but we’re all squared away. I also saw you made some merges to the PR to square away conflicts, thank you for that. I’ll take it from here. If you want more details on how our merges typically work, check out our contributing guide. Thanks for the contribution! |
astrogeco
changed the title
astrogeco
changed the title
astrogeco
changed the title
astrogeco
added
the
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 19, 2021
nasa/cFE#1482, Resolve sequence count auto-increment rollover bug nasa/osal#985, rename hooks to handlers nasa/osal#1000, propagate status code in OS_rmdir nasa/osal#1001, rework "unit-tests" to use macros nasa/osal#1003, remove extra newlines in utassert logs nasa/osal#990, Add test for object id inline functions nasa/osal#998, fixed invalid inputs for OS_mkdir nasa/osal#812, Improves config guide documentation
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 19, 2021
Combines: nasa/cFE#1508, cFE v6.8.0-rc1+dev580 nasa/osal#1006, osal v5.1.0-rc1+dev452 Includes: nasa/cFE#1482, Resolve sequence count auto-increment rollover bug nasa/cFE#1491, Correctly format code block section terminator nasa/cFE#1530, Fix typos in developer guide nasa/osal#985, rename hooks to handlers nasa/osal#1000, propagate status code in OS_rmdir nasa/osal#1001, rework "unit-tests" to use macros nasa/osal#1003, remove extra newlines in utassert logs nasa/osal#990, Add test for object id inline functions nasa/osal#998, fixed invalid inputs for OS_mkdir nasa/osal#812, Improves config guide documentation nasa/osal#987, Show CodeQL Preview
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 19, 2021
Combines: nasa/cFE#1508, cFE v6.8.0-rc1+dev580 nasa/osal#1006, osal v5.1.0-rc1+dev452 Includes: nasa/cFE#1482, Resolve sequence count auto-increment rollover bug nasa/cFE#1491, Correctly format code block section terminator nasa/cFE#1530, Fix typos in developer guide nasa/osal#985, rename hooks to handlers nasa/osal#1000, propagate status code in OS_rmdir nasa/osal#1001, rework "unit-tests" to use macros nasa/osal#1003, remove extra newlines in utassert logs nasa/osal#990, Add test for object id inline functions nasa/osal#998, fixed invalid inputs for OS_mkdir nasa/osal#812, Improves config guide documentation nasa/osal#987, Show CodeQL Preview Co-Authored-By: Jake Hageman <skliper@users.noreply.github.com> Co-Authored-By: Joseph Hickey <joseph.p.hickey@nasa.gov> Co-Authored-By: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-Authored-By: Alex Campbell <zanzaben@users.noreply.github.com> Co-Authored-By: Tobias Nießen <tniessen@users.noreply.github.com> Co-Authored-By: Jonathan Bohren <jbohren-hbr@users.noreply.github.com> Co-Authored-By: Andrei Tumbar <Kronos3@users.noreply.github.com>
astrogeco
removed
the
CCB:Ready
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
and add Perf Trigger and Perf Start commands to functional tests workflow
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#812, Add Perf API functional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
I noticed a few things missing from the documentation.
There were also duplicate entries in one of the tables
Partially addresses #384, #640, #672
Testing performed
(none)
Expected behavior changes
No impact to behavior
System(s) tested on
Gentoo Linux - amd64
Contributor Info
Andrei Tumbar (NASA JPL) andrei.tumbar@jpl.nasa.gov / andreitumbar@gmail.com